Skip to content

Conversation

@deepalisingh-r
Copy link
Contributor

@deepalisingh-r deepalisingh-r commented Feb 27, 2025

Tenant to Deploy to: eG Innovations Pvt Ltd

Description

Adding a new plugin for squaredup on premises application.

PR Creation Checklist:

  • PR title includes a descriptive title
  • Added a label: breaking or non-breaking
  • Added a label: bug-fix, new-plugin, internal or enhancement
  • PR description written
  • Validate script run

@deepalisingh-r
Copy link
Contributor Author

Adding a new plugin in squaredup

@shaswot77 shaswot77 changed the title Initial commit New eG Innovations Plugin Mar 3, 2025
@shaswot77 shaswot77 added new-plugin New DataSource for SquaredUp non-breaking Changes that will not break the existing functionality of a plugin labels Mar 3, 2025
Copy link

@AnEvilPenguin AnEvilPenguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The requested changes are small ones and mostly around changes to our tooling. Otherwise there's nothing specific that concerns me!

In an advisory category:

You're importing objects but not (that I can see...) actually using them anywhere. You could drop these to simplify things (internally we don't import objects that we don't use without a good reason. If you have a good reason then please feel free to ignore me!).

You've got both axios and node-fetch as dependencies, but I don't think you're using axios at all. I'd suggest dropping that as a dependency, if only to make the bundle smaller and faster.

At the moment you're not using the report object in any capacity that I can see (just the log object). You can use report.error and report.warning to send back messages to the user in much the same way that you can use log.error to send messages to the log file. Something to think about for a future iteration maybe.

There seem to be a lot of label roles in your metadata, including on things like dates. We're normally a bit more targeted in our use of these roles so I'm not sure how this will behave (I think previously this could create excessively long tooltips on line graphs, but it's also been a long time since I last saw that issue so it may no longer be a thing).

@gdorward
Copy link
Contributor

gdorward commented Jan 9, 2026

A failing unit test to look into @deepalisingh-r :

`FAIL packages/@squaredup/unit-test/dataStreamDefaults.test.js
● Data Stream dataSourceConfig defaults › eginnovations-v1 configurable data stream "Historical Data" dataSourceConfig default values correct

expect(received).toBeEmpty()

Expected value to be empty received:
  ["Field timeline has default value '\"1 hour\"' but dataSourceConfig has 'undefined'"]

  100 |                     const issues = [];
  101 |                     checkFields(cod.template, issues);
> 102 |                     expect(issues).toBeEmpty();
      |                                    ^
  103 |                 });
  104 |             }
  105 |         }

  at Object.toBeEmpty (packages/@squaredup/unit-test/dataStreamDefaults.test.js:102:36)`

@AnEvilPenguin AnEvilPenguin self-requested a review January 12, 2026 10:08
Copy link

@AnEvilPenguin AnEvilPenguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!

@gdorward
Copy link
Contributor

Approving based on the test evidence provided

@gdorward gdorward self-requested a review January 12, 2026 10:40
@gdorward gdorward merged commit 34f3760 into squaredup:main Jan 12, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-plugin New DataSource for SquaredUp non-breaking Changes that will not break the existing functionality of a plugin

Development

Successfully merging this pull request may close these issues.

5 participants